Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposer field is false though it's the only sequencer #1150

Open
omritoptix opened this issue Aug 26, 2024 · 3 comments
Open

proposer field is false though it's the only sequencer #1150

omritoptix opened this issue Aug 26, 2024 · 3 comments
Assignees

Comments

@omritoptix
Copy link
Contributor

Screenshot 2024-08-26 at 17 38 05

@zale144
Copy link
Contributor

zale144 commented Sep 2, 2024

the Proposer field is now deprecated and is never set to true. The only reason it's not deleted is because it is referenced in the v4 upgrade handler. Can we still remove the field @mtsitrin ?

@mtsitrin
Copy link
Contributor

mtsitrin commented Sep 3, 2024

@omritoptix this field is deprecated. it's not used anywhere but the migration handler to v4

@zale144
Copy link
Contributor

zale144 commented Sep 3, 2024

I suppose it's important how it's used:

if oldSequencer.Proposer {
	sequencerkeeper.SetProposer(ctx, oldSequencer.RollappId, oldSequencer.Address)
}

so, I think we're not in a hurry to remove it, we can leave it until running V4 upgrade on mainnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants