Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate all GenesisInfo fields upon genesis transfer to the hub #1208

Open
omritoptix opened this issue Sep 8, 2024 · 0 comments
Open

validate all GenesisInfo fields upon genesis transfer to the hub #1208

omritoptix opened this issue Sep 8, 2024 · 0 comments
Assignees

Comments

@omritoptix
Copy link
Contributor

omritoptix commented Sep 8, 2024

this could happen with or without IRO.
in the case of IRO - will be validated upon genesis transfer against the denom and memo.
In the case of non-iro, one way to validate it is to attach the relevant fields in the memo upon first transfer (unlike genesis transfer case - not necessarily the first transfer will be of the native denom, so we may need to inject the info of the native denom also there).

So in essence both contain genesis transfer, only the IRO genesis transfer gets a free pass and opens the bridge, and on the other case the genesis transfer is simply the first transfer from the rollapp (but doesn't get a free pass, and doesn't require to be the native denom)

We should also update the genesis bridge ADR.

@omritoptix omritoptix assigned zale144 and mtsitrin and unassigned zale144 Sep 8, 2024
@omritoptix omritoptix changed the title enforce initial_supply is correct in the genesis bridge validate all GenesisInfo fields upon first transfer to the hub Sep 15, 2024
@omritoptix omritoptix changed the title validate all GenesisInfo fields upon first transfer to the hub validate all GenesisInfo fields upon genesis transfer to the hub Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants