Plain doesn't seem to work (#15)

Author: e-minguez

README.md

@@ -13,7 +13,6 @@ Simple tool to convert files to MachineConfig objects to be used with the machin
 - [x] normalized parameters (...)
 - [x] multiple labels support
 - [x] base64 file encoded content support
-- [x] plain file content support
 - [x] json output
 - [x] yaml output
 
@@ -24,6 +23,10 @@ Simple tool to convert files to MachineConfig objects to be used with the machin
 - [ ] Good code
 - [ ] Better error handling
 
+## Not working
+
+- [ ] [plain file content support](https://github.com/e-minguez/file-to-machineconfig/issues/13)
+
 ## Usage
 
 Download the latest binary release:

file-to-machineconfig.go

@@ -32,7 +32,6 @@ func main() {
 	flag.StringVar(&data.APIVer, "apiversion", "", "MachineConfig API version")
 	flag.StringVar(&data.IgnitionVer, "ignitionversion", "", "Ignition version")
 	flag.IntVar(&data.Mode, "mode", 0, "File's permission mode in octal")
-	flag.BoolVar(&data.Plain, "plain", false, "Embed a plain file instead encoding it to base64 (false by default)")
 	flag.BoolVar(&data.Yaml, "yaml", false, "Use yaml output instead JSON (false by default)")
 
 	flag.Parse()

pkg/converter/converter.go

@@ -30,7 +30,6 @@ type Parameters struct {
 	IgnitionVer string
 	Content     string
 	Mode        int
-	Plain       bool
 	Yaml        bool
 }
 
@@ -54,15 +53,6 @@ func fileToBase64(file string) string {
 	return encodedcontent
 }
 
-// fileToPlain Create a single string from a file
-func fileToPlain(file string) string {
-	f, err := ioutil.ReadFile(file)
-	if err != nil {
-		log.Fatal(err)
-	}
-	return string(f)
-}
-
 // labelsToMap Creates a string map with the labels the user provides
 func labelsToMap(labels string) map[string]string {
 	// Remove blanks and split the labels by the comma
@@ -175,13 +165,8 @@ func NewMachineConfig(data Parameters) MachineConfig.MachineConfig {
 	// Default content will be base64
 	fileContent := "data:text/plain;charset=utf-8;base64,"
 
-	if data.Plain == true {
-		fileContent = fileToPlain(data.LocalPath)
-
-	} else {
-		// Create the base64 data with the proper ignition prefix
-		fileContent += fileToBase64(data.LocalPath)
-	}
+	// Create the base64 data with the proper ignition prefix
+	fileContent += fileToBase64(data.LocalPath)
 
 	// Create a map with the labels (as required by the machine-config struct)
 	labelmap := labelsToMap(data.Labels)