Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register binary attribute in collection.xconf.xsd #5436

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Register binary attribute in collection.xconf.xsd #5436

wants to merge 1 commit into from

Conversation

joewiz
Copy link
Member

@joewiz joewiz commented Aug 30, 2024 •
edited by duncdrum
Loading

Description:

Closes #5432 by adding schema definitions for the field element's binary attribute in the collection.xconf.xsd schema.

Reference:

#5432

Type of tests:

n/a

@joewiz joewiz requested a review from a team as a code owner August 30, 2024 22:13
@joewiz
Copy link
Member Author

joewiz commented Aug 30, 2024

SonarCloud's failure:

Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.20.0:site (default-site) on project exist: Failed to render site: Error generating maven-surefire-report-plugin:3.5.0:report report: Cannot invoke "Object.toString()" because "value" is null -> [Help 1]

The windows-latest checks haven't failed yet; they're still going, 30 minutes after submitting the PR...

@dizzzz
Copy link
Member

dizzzz commented Aug 31, 2024

it is a recurring issue.... I guess a plugin update is needed...

@dizzzz dizzzz requested review from line-o, reinhapa and a team August 31, 2024 09:09
@duncdrum
Copy link
Contributor

@joewiz did you mean issue to link to issue 5342 in the op, I corrected that as I don't see how that would be related

@joewiz
Copy link
Member Author

joewiz commented Aug 31, 2024

@duncdrum Thanks, yes!

@dizzzz The windows-latest checks finished... after 40 minutes - wow!

adamretter
adamretter suggested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this is fine, but I think perhaps we should just restrict the choices to "yes" and "no" so that it is consistent with the other elements in the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamretter adamretter adamretter requested changes

@dizzzz dizzzz dizzzz approved these changes

@line-o line-o Awaiting requested review from line-o

@reinhapa reinhapa Awaiting requested review from reinhapa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Register binary attribute in collection.xconf.xsd
4 participants
@joewiz @dizzzz @duncdrum @adamretter