Multiple issues with nodejs devfile

[JPinkney]

Description

While trying to dogfood Che I found multiple issues with the node devfile that makes working with it almost impossible right off the bat.

Just from the short video below I've found a few things:

• Git clone location prompt shows you by default somewhere that is different than /projects
  This dialog is being removed.
• Git clone gets permission denied
  Looks like you're trying to clone to /. User error?
• When opening up the node terminal it sets you to a location other than /projects
  Which container?
• Permission denied when running npm install
• yarn does not exist in the image (you can easily install it but a lot of projects I see use yarn)

https://www.youtube.com/watch?v=ep5nOJiL99w

Diagnostics:

7.0.0-rc-4.0-SNAPSHOT deployed via chectl onto minikube

[slemeur]

Please @tsmaeder and @tolusha give a look to this issue.
Probably related to eclipse-che/che-devfile-registry#29

[JPinkney]

If i'm not mistaken when I was testing it was using registry.access.redhat.com/ubi8/nodejs-10 as the image so my devfile must not have been updated. I'll try with the new one and report back.

[l0rd]

cc @skabashnyuk @sparkoo @ibuziuk

[ibuziuk]

I suspect that most of the issues would be fixed with https://github.com/eclipse/che-devfile-registry/tree/master/arbitrary-users-patch images - will try to check this assumption after CI setup

[tsmaeder]

@ibuziuk yes, looks like it. However, the fact that yarn is IMO one of the cases where the user will have to bring their own images. Not saying we can't offer a devfile with yarn installed, but there will always be that "one more tool" some user needs that is not installed on any of the packaged devfiles.

[JPinkney]

Looks like you're trying to clone to /. User error?

I would have expected that if projects is selected in the dialog that it would clone to /projects maybe that's an user error, maybe its not, that's just what I expected. I tried double clicking on /projects and it brought me to
and then when I selected 'Select Repository Location' the error that came up was

Git: fatal: could not create work tree dir '/schemastore': Permission denied

(I was test cloning https://github.com/schemaStore/schemastore)

Whats interesting is I was able to successfully clone it in other locations like theia/node_modules/@eclipse-che/api folder.

Which container?

Its the container with alias nodejs
From the devfile:

type: dockerimage
image: registry.access.redhat.com/ubi8/nodejs-10
alias: nodejs

However, the fact that yarn is IMO one of the cases where the user will have to bring their own images.

True, I'm just sad I have to do that myself 😉

[tsmaeder]

It all works. The fact that yarn is not installed is not a bug.

[slemeur]

@tsmaeder : Could you create an enhancement issue to add "yarn" by default in the default nodejs stack? Because I agree with the initial requirement, that gets pretty "standard" and a lot of projects are using it. Having it, would be beneficial to end-users.

[slemeur]

ping @tsmaeder ???

[slemeur]

#14720