Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jersey update from 3.1.3 to 3.1.4 slows down our external service response times drastically #5738

Open
rehmatt opened this issue Sep 3, 2024 · 2 comments

Comments

@rehmatt
Copy link

rehmatt commented Sep 3, 2024

Hi,

we've recently updated our services from jersey 3.1.2 to 3.1.5 and encountered drastically worse response times for our external service calls which are using jerseys HttpUrlConnector.

With downgrading to 3.1.3 everything was fine again, but updating to 3.1.4 again let the response times rise by 50% to 120%.

Having a look on the changes between 3.1.3 and 3.1.4 I saw the following PR: #5359.
It introduced a synchronized block inside getConnection(URL url, Proxy proxy):

default HttpURLConnection getConnection(URL url, Proxy proxy) throws IOException {
    synchronized (this){
        return (proxy == null) ? getConnection(url) : (HttpURLConnection) url.openConnection(proxy);
    }
}

If I interpret it correctly this will lead to only one thread being able to open a connection with the connector. As we have many threads processing incoming requests with one connector per external service, it might happen that there are many threads which want to get a connection, but only one at a time is possible.

Screenshot 2024-09-03 at 15 25 05

Is this already a known issue? Is my assumption regarding the synchronized block correct?

@fwippe
Copy link

fwippe commented Sep 4, 2024

Just to put this into perspective: If I'm not mistaken, the fact that getConnection is synchronized on HttpUrlConnector ultimately means that only one connection at a time may be created across all services handled by Jersey. This is potentially a catastrophic performance regression.

@jankadel
Copy link

jankadel commented Sep 4, 2024

Great finding! I was wondering why my services became slower when I upgraded Jersey.

This was referenced Sep 4, 2024
jbescos added a commit to jbescos/jersey that referenced this issue Sep 23, 2024
jbescos added a commit to jbescos/jersey that referenced this issue Sep 23, 2024
jbescos added a commit to jbescos/jersey that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants