MqttMsgBase - implement mqtt message length requirements (2.2.3 Remaining Length)

Author: mwallnoefer

M2Mqtt/Exceptions/MqttClientException.cs

@@ -127,6 +127,12 @@ public enum MqttClientErrorCode
         /// <summary>
         /// Invalid protocol name
         /// </summary>
-        InvalidProtocolName
+        InvalidProtocolName,
+
+        // [v3.1.1]
+        /// <summary>
+        /// Invalid message length
+        /// </summary>
+        InvalidLength
     }
 }

M2Mqtt/Messages/MqttMsgBase.cs

@@ -174,6 +174,9 @@ protected int encodeRemainingLength(int remainingLength, byte[] buffer, int inde
                     digit = digit | 0x80;
                 buffer[index++] = (byte)digit;
             } while (remainingLength > 0);
+
+            if (index > 4) // 4 bytes [0..3] is the maximum allowed (2.2.3 Remaining Length)
+                throw new MqttClientException(MqttClientErrorCode.InvalidLength);
             return index;
         }
 
@@ -188,13 +191,18 @@ protected static int decodeRemainingLength(IMqttNetworkChannel channel)
             int value = 0;
             int digit = 0;
             byte[] nextByte = new byte[1];
+            int index = 0;
             do
             {
                 // next digit from stream
                 channel.Receive(nextByte);
                 digit = nextByte[0];
                 value += ((digit & 127) * multiplier);
                 multiplier *= 128;
+                ++index;
+
+                if (index > 4) // 4 bytes [0..3] is the maximum allowed (2.2.3 Remaining Length)
+                    throw new MqttClientException(MqttClientErrorCode.InvalidLength);
             } while ((digit & 128) != 0);
             return value;
         }