Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inside Win-Unpacked Application is getting Default Electron Icon #8634

Open
Mrinanga opened this issue Oct 26, 2024 · 2 comments
Open

Inside Win-Unpacked Application is getting Default Electron Icon #8634

Mrinanga opened this issue Oct 26, 2024 · 2 comments

Comments

@Mrinanga
Copy link

  • Electron-Builder Version:
  • Node Version:
  • Electron Version:
  • Electron Type (current, beta, nightly):
  • Target:
@drewklein20
Copy link

This worked for me:
#5784 (comment)

@mmaietta
Copy link
Collaborator

This is correct ☝️ . signAndEditExecutable: true is what executes rcedit.exe, which is what applies the icon to the executable. I've investigated in the past if it's possible to split the rcedit.exe and signing logic, however, I'm not sure on the implications of doing so since they've always been executed together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants