Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer repositories & NPM packages from mongodb-js to electron-userland #7

Open
malept opened this issue May 11, 2018 · 27 comments
Open

Comments

@malept
Copy link
Member

malept commented May 11, 2018

Following on conversation from electron-userland/electron-installer-dmg#25 (comment):

@MarshallOfSound is interested in moving electron-installer-dmg and electron-squirrel-startup over, as they're used in Electron Forge.

I'm kind of interested in electron-installer-zip since there's a link to it in the Electron Packager "related" section and it needs some updates (zip-folder has issues, as we've found out in Forge)

CC: @imlucas @zeke

@zeke
Copy link
Member

zeke commented May 11, 2018

Sounds like a great idea. 👍

I wonder what we should do about npm ownership. 🤔

One way to handle it:

  1. create electron-userland-bot account on npm
  2. create @electron-userland-bot account on GitHub
  3. npm owner add electron-userland-bot
  4. set up semantic-release

This way releases would happen automatically, no matter who's landing pull requests.

@malept
Copy link
Member Author

malept commented May 11, 2018

I wonder what we should do about npm ownership.

There's an electron-userland team in NPM that we should add more of the -userland admins (and -userland packages) to. Unfortunately only the package creator can move it, it seems. ETA: I just checked and apparently that restriction is now gone.

@zeke
Copy link
Member

zeke commented May 11, 2018

There's an electron-userland team in NPM

Cool. Can you add me to it?

@malept
Copy link
Member Author

malept commented May 11, 2018

@zeke added.

@imlucas
Copy link

imlucas commented May 12, 2018

This is great :) A few 🤔:

  1. Guessing we move these packages over from mongodb-js npm org to electron-userland?

  2. Repos: transfer to electron-userland gh org?

  3. For the electron-* packages not listed above but are dependencies of those listed: should we also transfer these over so you all can refactor them out, deprecate, and move to archive?

For more context: these were all created to get https://compass.mongodb.com/ off the ground by going through atom build scripts and breaking them out into sep modules w strong testing. @durran is in Berlin and @rueckstiess is in Sydney so if I broke the build, they’d be stuck for 1 day or more until I could patch.

Longer term: https://www.github.com/mongodb-js/hadron-build is ~equivalent to forge. So, might make sense for us to move to forge @durran

The hadron-* projects might be a bit higher level for electron-userland but curious to discuss and I haven’t had ☕️ yet. Hadron provides the groundwork for building plugin based electron apps like atom, compass, and nylas. Would that be out of scope for electron-userland? IMO, hadron is incomplete today in terms of its aspirations. It would be sweet to get more community involvement here so it can be completed and enable others to build plugin based electron apps.

cc @aydrian @durran @rueckstiess @mrlynn

@zeke
Copy link
Member

zeke commented May 13, 2018

☝️ that all sounds good to me, @imlucas

@MarshallOfSound
Copy link
Member

@imlucas

  1. 👍

  2. 👍

  3. Do we have a list of these modules, I wasn't aware they had nested electron-* deps 😄 But yeah we'll probably take them on board and then refactor them out if they aren't worth the maintenance cost.

RE hadron-build yeah let us know if electron-forge is missing anything major for you to use it, it appears to be basically semantically equivalent. Especially with v6 round the corner.

RE the hadron-* plugin based stuff that's definitely a discussion I'd like to have at some point, for instance I spent a few months last year some time working on electron-ionizer which I think had more a less the same goals (making plugin based Electron apps easier to build).

But yeah, 1, 2 and 3 should definitely be easy to sort out 👍

@MarshallOfSound
Copy link
Member

cc @imlucas Can we move forward with this plan?

@zeke
Copy link
Member

zeke commented Jul 6, 2018

Plan looks good to me. Let me know if you need my help for any of it.

@durran
Copy link

durran commented Jul 10, 2018

I’ll get on this tomorrow.

@durran
Copy link

durran commented Jul 11, 2018

Just as a heads up here. I need temporary admin permissions in the electron-userland org (at least repo creation) to be able to transfer the repos over on Github. Once the transfer is complete please feel free to revoke my permissions.

The repos I am going to transfer are:

https://github.com/mongodb-js/electron-installer-squirrel-windows
https://github.com/mongodb-js/electron-installer-zip
https://github.com/mongodb-js/electron-installer-dmg

Please let me know if there are others I should include as well.

@malept
Copy link
Member Author

malept commented Jul 11, 2018

@durran invite sent.

@MarshallOfSound
Copy link
Member

@durran Can you also add @malept and myself to the modules on NPM 👍

@durran
Copy link

durran commented Jul 11, 2018

Those 3 I noted are now transferred. I'll do the npm access next.

@durran
Copy link

durran commented Jul 11, 2018

@MarshallOfSound Can you please provide yours and @malept's npm usernames and/or emails?

@durran
Copy link

durran commented Jul 11, 2018

If not here you can email me directly at [email protected] or [email protected]

@MarshallOfSound
Copy link
Member

Mine is the same as my github username.

https://www.npmjs.com/~marshallofsound

@MarshallOfSound
Copy link
Member

Malept is the same, https://www.npmjs.com/~malept

@durran
Copy link

durran commented Jul 11, 2018

Both should have permission on npm now.

@durran
Copy link

durran commented Jul 11, 2018

And since the Github repos are now transferred please take away my privs. ;)

@malept
Copy link
Member Author

malept commented Jul 11, 2018

@durran I just checked and none of the three packages are in my list in the NPM UI.

@malept
Copy link
Member Author

malept commented Jul 11, 2018

@durran you have been removed from the GitHub org as requested 😄

@durran
Copy link

durran commented Jul 11, 2018

I just checked as well and see the same. I'll try again.

@durran
Copy link

durran commented Jul 11, 2018

I've temporarily given both of you admin access to the mongodb-js org and that seemed to work fine. For some reason my attempts to give both of your ownership to those repos both via the command line and in the web interface never worked. Maybe you have access now?

@MarshallOfSound
Copy link
Member

@durran I have added those 3 modules successfully to the electron-userland org on NPM. You should be able to remove them from the mongodb-js org now if you want 👍

@durran
Copy link

durran commented Jul 12, 2018

Great. Thank you so much!

@malept
Copy link
Member Author

malept commented Jul 12, 2018

I was about to close this and I realized that we didn't move over electron-squirrel-startup yet. @MarshallOfSound do we still want to transfer this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants