Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #26

Closed
msaraiva opened this issue Aug 7, 2019 · 8 comments
Closed

Release v2.0.0 #26

msaraiva opened this issue Aug 7, 2019 · 8 comments

Comments

@msaraiva
Copy link
Collaborator

msaraiva commented Aug 7, 2019

I think it's time to publish a new release since we already have some nice new features and a bunch of fixes/improvements. Unless any of you has something else in mind, I'm planning to to this after #20, #25 and #24 are implemented and merged.

/cc @axelson, @@lukaszsamson

@axelson
Copy link
Member

axelson commented Aug 7, 2019

Sounds good to me! There's been a bunch of improvements. Although if there aren't any breaking changes the new version could just be 1.1.0.

@lukaszsamson
Copy link
Collaborator

I'm currently working on better support for protocols. I plan to finish it in a few days.
@axelson I'm not sure if there are going to be any breaking changes. My PRs were mostly bugfixes and new features. Elixir ecosystem does not show much appreciation to semver anyway.

@msaraiva
Copy link
Collaborator Author

msaraiva commented Aug 8, 2019

There should be no breaking changes for clients using only the ElixirSense module. However, I can confirm at least one breaking change regarding ElixirLS, which uses Introspection directly, as stated here #20 (comment). So maybe v2.0.0 makes sense.

@lukaszsamson
Copy link
Collaborator

@axelson do you have elixir-lsp organization hex.pm credentials? @msaraiva I know you published 1.0 from your personal account

@axelson
Copy link
Member

axelson commented Aug 17, 2022

@lukaszsamson there isn't an elixir-lsp organization. I don't think hex.pm generally uses organizations for this, according to the mix hex.organization docs, organizations are for managing private packages. I think what we probably want to do is ask @msaraiva to add you as an owner to https://hex.pm/packages/elixir_sense

@msaraiva
Copy link
Collaborator Author

@lukaszsamson yeah, I need to add you as owner. What's your username on hex?

@lukaszsamson
Copy link
Collaborator

What's your username on hex?

@msaraiva lukaszsamson

@lukaszsamson
Copy link
Collaborator

What's your username on hex?

@msaraiva lukaszsamson

ping @msaraiva

@lukaszsamson lukaszsamson closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants