Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A vs emberA #79

Open
kellyselden opened this issue Nov 14, 2017 · 1 comment
Open

A vs emberA #79

kellyselden opened this issue Nov 14, 2017 · 1 comment

Comments

@kellyselden
Copy link
Contributor

The codemod gave me some

import { A } from '@ember/array';

I thought the preferred style was

import { A as emberA } from '@ember/array';

Am I mistaken, or was this overlooked?

@rwjblue
Copy link
Member

rwjblue commented Nov 14, 2017

I personally prefer a slightly more verbose (but much less cryptic) import { A as createEmberArray } from '@ember/array' 😝 , but either way I agree that a local var named A is not great...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants