Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{model}} in route templates should be transformed to {{@model}} #106

Open
jelhan opened this issue Jan 18, 2020 · 1 comment
Open

{{model}} in route templates should be transformed to {{@model}} #106

jelhan opened this issue Jan 18, 2020 · 1 comment

Comments

@jelhan
Copy link
Contributor

jelhan commented Jan 18, 2020

{{model}} in route templates is transformed to {{this.model}} but should be {{@model}} in my opinion. At least if ember-source is >= 3.14 and if the backing controller does not have a model property.

Copy link
Member

rwjblue commented Mar 29, 2020

The issue with this is that @model will not match / handle special handling that folks have done in setupController (and therefore make the codemod less safe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants