Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pods? #36

Open
scottkidder opened this issue Oct 23, 2019 · 5 comments
Open

Support for pods? #36

scottkidder opened this issue Oct 23, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@scottkidder
Copy link

Is it possible for this codemod to support pods layout?

@NullVoxPopuli
Copy link
Collaborator

Does it not support pods? I haven't tested

@scottkidder
Copy link
Author

I've only tried our app so far. I haven't investigated but it appears to not properly associate the files with the telemetry output causing every file to be skipped.

Here is an example line from codemods.log:

2019-10-23T15:28:39.135Z [warn] [app/components/account-listing/template.hbs]: SKIPPED Could not find runtime data NO_RUNTIME_DATA

@NullVoxPopuli
Copy link
Collaborator

Thanks! That's helpful! Can you open an issue on the codemod telemetry repo as well? The helpers for accessing info by path live in that repo

@pabloascarza
Copy link

Hi in this issue in angle brackets codemod ember-codemods/ember-angle-brackets-codemod#217 running with --no-telemetry do the trick for me in my pods projects. Anyone knows if you can use that here?

@ijlee2
Copy link

ijlee2 commented Jul 22, 2022

For those who land on this issue, I wrote a codemod to un-pod Ember projects. Maybe try it out as a prerequisite to running ember-no-implicit-this-codemod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants