Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for usage in npm and yarn repos #9630

Closed
NullVoxPopuli opened this issue Jan 8, 2025 · 0 comments · Fixed by #9633
Closed

Add tests for usage in npm and yarn repos #9630

NullVoxPopuli opened this issue Jan 8, 2025 · 0 comments · Fixed by #9633

Comments

@NullVoxPopuli
Copy link
Contributor

To help prevent stuff like this:

I'm thinking we copy a select few sample apps to a tmp directory in CI, copy some packed deps (tars), edit the package.json, and make sure stuff like type check, and a super basic test passes

@github-project-automation github-project-automation bot moved this to needs triage in EmberData Jan 8, 2025
gitKrystan pushed a commit that referenced this issue Feb 11, 2025
* Correctly configure package.json#exports for use with tsconfig.json#compilerOptions#types

Fix: #9630
Fix: ember-cli/ember-cli#10611

Related:
- ember-cli/ember-cli#10613

Unblocks:
- ember-cli/ember-cli#10612

* Fix lints by removing eslint cache

* Smoke Tests: dt-types pass

* Smoke: native-types pass

* ope

* Revert changes to vite-basic-compat

* lockfile

* Revert npmrc

* revert pnpm-lock

* Smoke tests don't need their own lint config

* Use correct script name

* Remove added files to vite-basic-compat

* Prettier

* Revert misguided lint-induced changes
gitKrystan pushed a commit that referenced this issue Feb 18, 2025
* Correctly configure package.json#exports for use with tsconfig.json#compilerOptions#types

Fix: #9630
Fix: ember-cli/ember-cli#10611

Related:
- ember-cli/ember-cli#10613

Unblocks:
- ember-cli/ember-cli#10612

* Fix lints by removing eslint cache

* Smoke Tests: dt-types pass

* Smoke: native-types pass

* ope

* Revert changes to vite-basic-compat

* lockfile

* Revert npmrc

* revert pnpm-lock

* Smoke tests don't need their own lint config

* Use correct script name

* Remove added files to vite-basic-compat

* Prettier

* Revert misguided lint-induced changes
MehulKChaudhari pushed a commit to MehulKChaudhari/ember-data that referenced this issue Mar 16, 2025
* Correctly configure package.json#exports for use with tsconfig.json#compilerOptions#types

Fix: emberjs#9630
Fix: ember-cli/ember-cli#10611

Related:
- ember-cli/ember-cli#10613

Unblocks:
- ember-cli/ember-cli#10612

* Fix lints by removing eslint cache

* Smoke Tests: dt-types pass

* Smoke: native-types pass

* ope

* Revert changes to vite-basic-compat

* lockfile

* Revert npmrc

* revert pnpm-lock

* Smoke tests don't need their own lint config

* Use correct script name

* Remove added files to vite-basic-compat

* Prettier

* Revert misguided lint-induced changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant