New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect nindent for initContainers in helm chart #5703

Open

SeanKnight opened this issue Jun 24, 2024 · 1 comment

Labels

t:bug

SeanKnight commented Jun 24, 2024

Describe the bug

Can not add my own initContainer if .Values.waitForApiext.enabled is true

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment.yaml#L178

nindent on line 178 should be 6 to match the indent used on wait-for-apiext on line 136

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment.yaml#L136

To Reproduce

Steps to reproduce the behavior:

Set .Values.waitForApiext.enabled to true (default setting)
In values.yaml define one or more .initContainers
Template or install chart and get invalid yaml

Expected behavior

To be able to define additional initContainers.

Versions (please complete the following information):

Chart version >=8.9.0

Additional context

Incorrect indent also in this file:

https://github.com/emissary-ingress/emissary/blob/chart/v8.9.1/charts/emissary-ingress/templates/deployment-canary.yaml#L157

The text was updated successfully, but these errors were encountered:

Author

SeanKnight commented Jun 24, 2024

Related:

cindymullins-dw added the t:bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment