Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create emissary-ingress.dev/v4 CRDs #5712

Open
kflynn opened this issue Jun 28, 2024 · 1 comment
Open

Create emissary-ingress.dev/v4 CRDs #5712

kflynn opened this issue Jun 28, 2024 · 1 comment

Comments

@kflynn
Copy link
Member

kflynn commented Jun 28, 2024

We have to bump the CRD version anyway, because removing header casing and error response rewriting is a breaking change, and we'd like to be able to get away from apiext for green-field installations of Emissary 4, but we'd also like to not force forklift upgrades from Emissary 3. The way to make all of these things work is to have a new API group.

emissary-ingress.dev/v4 CRDs should mostly look like getambassador.io/v3alpha1, but:

  • rip out stuff lingering from v2
  • rip out header casing and error response rewriting
  • use camelCase instead of snake_case

and yes, we'll all but certainly start with v4alpha1 but let's not stop there.

@kflynn
Copy link
Member Author

kflynn commented Jul 3, 2024

Note that we run into the shortname collision problem here, too: does kubectl get Mapping mean mapping.getambassador.io or mapping.emissary-ingress.dev? We should think about that, and how to alleviate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant