Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_client.py should be merged and dedup'd into test_async_client.py #681

Closed
florimondmanca opened this issue Dec 23, 2019 · 2 comments
Closed
Labels
refactor Issues and PRs related to code refactoring tooling Changes to our CI/CD, tests setup, etc.

Comments

@florimondmanca
Copy link
Member

This is a piece of technical debt remaining from #544: tests for Client are present (and mostly duplicated) across test_async_client.py and test_client.py.

I've been feeling we should clean that up for a while, and we do need to address it before re-introducing sync, so just tracking it here. :-)

@florimondmanca florimondmanca added tooling Changes to our CI/CD, tests setup, etc. refactor Issues and PRs related to code refactoring labels Dec 23, 2019
@florimondmanca florimondmanca changed the title Clean up test_async_client.py / test_client.py test_client.py should be merged and dedup'd into test_async_client.py Dec 23, 2019
@tomchristie
Copy link
Member

I think we’ll likely end up going the other way on this - leave it in because a sync client is imminent (even if the sync dispatch isn’t quite there)

@tomchristie
Copy link
Member

Now redundant given #735 (Which reintroduces proper sync tests in test_client.py.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs related to code refactoring tooling Changes to our CI/CD, tests setup, etc.
Projects
None yet
Development

No branches or pull requests

2 participants