Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub composite action for CI workflow #2457

Open
leotm opened this issue Sep 17, 2024 · 2 comments
Open

Create GitHub composite action for CI workflow #2457

leotm opened this issue Sep 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@leotm
Copy link
Contributor

leotm commented Sep 17, 2024

What is the Problem Being Solved?

Clean up CI tech debt to avoiding duplication, finishing what we started 4y ago

# This file has necessary redundancies since of github actions aren't supporting:
# - the definition of macros, which could be called from each job.
# - reporting the status of steps in the PR (only jobs and workflows are reported).
# Steps between "begin" and "end" should be the same in every job.

so replace all our begin/end macro comments with a GH composite action

spotted earlier by @boneskull

Description of the Design

e.g. uses: endojs/[email protected] (or mvp via filepath)

the alternative is a reusable workflow

Security Considerations

Scaling Considerations

this improves scaling CI jobs

Test Plan

Testing out your action in a workflow

local testing works well with nektos/act

Compatibility Considerations

consider: linux / windows / macOS

Upgrade Considerations

upgrading this composite actions to e.g. uses: endojs/[email protected] involves pushing a new tag (unless using commit sha)

@leotm leotm added the enhancement New feature or request label Sep 17, 2024
@boneskull
Copy link
Contributor

@leotm Can you make sure that we only lint once? Currently, we're running the lint workflow on multiple versions of Node.js, which wastes cycles

@leotm
Copy link
Contributor Author

leotm commented Oct 3, 2024

@leotm Can you make sure that we only lint once? Currently, we're running the lint workflow on multiple versions of Node.js, which wastes cycles

nb (thx @kriskowal beat me to it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants