Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists support #132

Open
snowc0de opened this issue Jan 25, 2020 · 31 comments
Open

Playlists support #132

snowc0de opened this issue Jan 25, 2020 · 31 comments
Labels
feature request WIP Work in progress

Comments

@snowc0de
Copy link

Hello!
I love your app and I wanted to know if a playlist feature will be implemented.

Thanks in advance!

@enricocid
Copy link
Owner

Yes, it is scheduled for 4.2.x :)
Unfortunately I actually don't have a physical test device (nexus 5 is broken and can't use daily device) but only the android studio emulator so I can test/debug only minor changes (i.e. review already working implementations) but not complex features like this.

@enricocid enricocid changed the title FEATURE REQUEST: Getting playlists Playlists support Jan 25, 2020
@snowc0de
Copy link
Author

Thanks for your quick abswer and thanks for this cool project!

@ghost
Copy link

ghost commented Jan 31, 2020

If there's a branch in progress I can test, I have a few extra devices around

@enricocid
Copy link
Owner

If there's a branch in progress I can test, I have a few extra devices around

Actually not. Anyway, I'm implementing the database to handle music storing (and that I will use to manage playlists), but it will require time. I will post test apk asap.Thanks

@enricocid
Copy link
Owner

enricocid commented Feb 2, 2020

Hi,

this is a debug apk with the database impl.
Basically it is needed to fix an issue related to MediaStore querying that makes the music disappear or the app to crash (that I'm still not able to reproduce) after some days of usage. To reduce accesses to MediaStore I have then to implement a database where to store the music (there's also an option to reset the db).
This issue is present also on Phonograph and Shuttle and all the players running a MediaStore query at boot.

This version (4.2.0) is the first step for the playlists implementation (it will require time anyway as I have to find the proper db schema to store playlists) so I need users to test db implementation :)

https://drive.google.com/open?id=11rlrz290vam4FpMD-pxmZxf7Vyzrel-H

Thanks

ps: I now have a one plus for testing :)

@enricocid
Copy link
Owner

enricocid commented Feb 3, 2020

Try this one

https://drive.google.com/open?id=17TALVLCygtEibt4fmYLJVAptHb-VNbc_

The db building process was very slow on previous apk when in presence of a large library.
This is much faster.
Let me know if this works good for You

@ghost
Copy link

ghost commented Feb 4, 2020

So far it's working well, the second one provided. I've been using it today with no issue. I will continue for a few days and let you know.

Is there anything in particular I should test, manging playing queue or favorites maybe?

@enricocid
Copy link
Owner

So far it's working well, the second one provided. I've been using it today with no issue. I will continue for a few days and let you know.

Is there anything in particular I should test, manging playing queue or favorites maybe?

I'm doing some impl review. Gonna post some apk later this week and I will let You know :)

@enricocid
Copy link
Owner

enricocid commented Feb 8, 2020

Just to inform You I've implemented some basic code ... anyway, I'm experiencing issues with persistence of music database (hope i will be able to fix this issue)...
I need some more time to implement deletion of playlists, songs and other things :)
Gonna post code and an apk soon
Senza nome

@enricocid
Copy link
Owner

This is the branch where database / playlist changes will be pushed

https://github.com/enricocid/Music-Player-GO/tree/master-database-playlist

Unfortunately there are issues with devices holding music on external sdcard, which makes the actual db implementation not reliable.

@ghost
Copy link

ghost commented Dec 30, 2020

I love this app and playlist is only feature I miss in this application. When I saw this feature request I hoped that I could use playlists soon but now I see that there is no progress on this feature for an year. Is there any change it will be implemented?

@RickyM7 RickyM7 mentioned this issue Dec 31, 2020
20 tasks
@enricocid
Copy link
Owner

enricocid commented Dec 31, 2020

I love this app and playlist is only feature I miss in this application. When I saw this feature request I hoped that I could use playlists soon but now I see that there is no progress on this feature for an year. Is there any change it will be implemented?

Yes,
but it will require some time.

I first have to change the way the app scans for music because of MediaStore issues. Playlist would disappear (phonograph has the same problem) or there could be issues if I don't mitigate this problem with mediastore.
I already tried but it's pretty difficult.

I'm actually focusing on stability :) I will add this feature in 2021.

@github-account1111
Copy link

Hold up. This music player has no playlist support? Lol if true

@snowc0de
Copy link
Author

Hold up. This music player has no playlist support? Lol if true

This project is pretty recent I think and most of the work is done by just a few people. I think this is understandable.

@github-account1111
Copy link

First entry in Releases is from May 2018, so not really.
And that one's "2.3.3.2" so there might've been more before it.

@enricocid
Copy link
Owner

enricocid commented Nov 29, 2021

Hmm, no.

Just personal builds I decided to share with the community at some point. It was even simpler than the current iteration.

As mentioned by @chopin2712 few people are involved full-time in the project and it is me.

Me, @enricocid, I'm actually involved in many other things included a covid-19/vaccines monitoring project in my country.

So yeah, MPGO is not a priority at the moment. It never was. I'm a developer only in my spare time. A scientist in real life.

If you need playlists just move to another player @github-account1111 👍🏻

Thanks for your comprehension.

@github-account1111
Copy link

I did 👍🏻
Just saying something as basic as playlists should probably be present in alpha builds, let alone version 1, let alone version 4.4.9.

@enricocid
Copy link
Owner

I'm sorry to inform you that this isn't a "basic" feature.

@snowc0de
Copy link
Author

It's not because you use a feature everyday that this feature isn't time consuming to implement.

@enricocid
Copy link
Owner

enricocid commented Nov 30, 2021

I already have a working implementation @chopin2712 but need time to solve some issues (supporting other android versions, database size/performance issues, mediastore issues, etc.)
Actually I'm involved in other projects and don't have much time. That's why I'm focusing on stability and maintenance.

I cannot make any promises at the moment, but I will try to further develop the current implementation during the holidays.

@github-account1111
Copy link

I'm sorry to inform you that this isn't a "basic" feature.

You should be, because you're wrong.
Playlists have been fundamental to music listening for ages.

@snowc0de
Copy link
Author

I'm sorry to inform you that this isn't a "basic" feature.

You should be, because you're wrong. Playlists have been fundamental to music listening for ages.

I think @enricocid meant "easy" by "basic".

@github-account1111
Copy link

I was the one that said basic in the first place. @enricocid just decided to reinterpret what I said for some reason.

@enricocid
Copy link
Owner

enricocid commented Dec 1, 2021

"Keep in mind that this app is built around the developer's usage needs and is shared for the love of libre software." (FAQ)

I don't consider playlists a "basic" feature.

That's it.

@SiddharthJ3
Copy link

@enricocid Just installed this app and it is wonderfull... its sleek and minimal...
It might be a strange req but consider changing its name to just "GO" (so that app name only shows "GO") ... it'll look cooler..

@felixniemeyer
Copy link

Great app. Just got here because I'd appreciate a playlists feature as well :)

@zivlakmilos
Copy link

Any update on this topic?

@enricocid
Copy link
Owner

enricocid commented Jul 14, 2022

Still on my to do list. Unfortunately, because of my new job I don't have much free time to dedicate to mpgo so I can focus only on small implementations and bug fixes at the moment.

Once possible I will address this issue 😆

4.5.0 could be the release.
I will slowly start the implementation within the next few hours/days, in my spare time ... as soon as 4.4.19 is ready for production! 👍🏻

@zivlakmilos
Copy link

Thank You. 😄

@enricocid enricocid added the WIP Work in progress label Jul 28, 2022
@enricocid
Copy link
Owner

#482

@enricocid
Copy link
Owner

:)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request WIP Work in progress
Projects
None yet
Development

No branches or pull requests

6 participants