Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_inspector cannot handle valid HTTP inspection that requires >8192 bytes to resolve #36162

Open
howardjohn opened this issue Sep 16, 2024 · 1 comment

Comments

@howardjohn
Copy link
Contributor

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
[email protected] where the issue will be triaged appropriately.

Title: http_inspector cannot handle valid HTTP inspection that requires >8192 bytes to resolve

Description:
We discovered an issue in the http_inspector where requests that are valid HTTP but exceed 8192 bytes cause the filter execution to hang.

You can see we will hit this code path at which point we have stopped iteration, but we are also at the max size we are willing to read.

Contrast this to the TLS Inspector code which dynamically changes how much it will read.

Repro steps:
Send a request with an >8192 byte url. I used the query param, not sure it matters

@howardjohn howardjohn added bug triage Issue requires triage labels Sep 16, 2024
@kyessenov
Copy link
Contributor

CC @briansonnenberg since you were looking into hardening the extension.

@zuercher zuercher added area/http and removed triage Issue requires triage labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants