Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_dfp_mixed_scheme deprecation #31973

Closed
alyssawilk opened this issue Jan 23, 2024 · 6 comments · Fixed by #36199
Closed

envoy_reloadable_features_dfp_mixed_scheme deprecation #31973

alyssawilk opened this issue Jan 23, 2024 · 6 comments · Fixed by #36199
Assignees
@alyssawilk @krajshiva
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@alyssawilk
Copy link
Contributor

Your change #27407 (dns: changing cache keys to include port to avoid issues) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
@alyssawilk alyssawilk added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Jan 23, 2024
@alyssawilk alyssawilk self-assigned this Jan 23, 2024
@alyssawilk
Copy link
Contributor Author

@yanavlasov @krajshiva this one is blocked on google yes? AFIK we never closed the loop upstream

@krajshiva
Copy link
Contributor

The problem call site is fixed here #27641 and is imported so we should be good to use new code. I will verify with the team once more by pinging them.

@krajshiva
Copy link
Contributor

actually there is another team that also has dependency on it. will check with them.

@alyssawilk
Copy link
Contributor Author

@krajshiva ping on this?

@alyssawilk
Copy link
Contributor Author

ping :-)

@alyssawilk
Copy link
Contributor Author

Hey @krajshiva can you circle back on this so we can remove it?

@alyssawilk alyssawilk mentioned this issue Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

@krajshiva krajshiva

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime: deprecating dfp_mixed_scheme alyssawilk/envoy
2 participants
@alyssawilk @krajshiva