http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes #36203
+75
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Anderson <[email protected]>
Signed-off-by: Adam Anderson <[email protected]>
Signed-off-by: Adam Anderson <[email protected]>
…-reset-error-codes Signed-off-by: Adam Anderson <[email protected]>
Signed-off-by: Adam Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: http2: improve coordination between StreamResetReason and HTTP2 RST_STREAM error codes
Additional Description: See linked issue. This PR makes locally-originated resets use more reasonable HTTP2 error codes, especially focusing on not using NO_ERROR where inappropriate. It also improves the translation of HTTP2 error codes into StreamResetReasons for remote-originated HTTP2 resets. An integration test is included which tests the scenario outlined in the linked issue.
Risk Level: medium. this may change behavior for existing http2 clients.
Testing: included, may need more (?)
Docs Changes: n/a
Release Notes: included
Fixes #36200