Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote address ratelimit metrics cannot be converted to prometheus format #4281

Open
zirain opened this issue Sep 19, 2024 · 4 comments
Open
Labels
area/observability Observability related issues

Comments

@zirain
Copy link
Contributor

zirain commented Sep 19, 2024

ratelimit.service.rate_limit.gateway-conformance-infra/same-namespace/http.httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*_httproute/gateway-conformance-infra/cidr-ratelimit/rule/0/match/0/*.masked_remote_address_0.0.0.0/0.remote_address.over_limit

. is a key word in statsd we should avoid to use it in descriptor.

Originally posted by @zirain in #4272 (comment)

@zirain zirain added the area/observability Observability related issues label Sep 19, 2024
@arkodg
Copy link
Contributor

arkodg commented Sep 19, 2024

needs to be fixed upstream ?

@zirain
Copy link
Contributor Author

zirain commented Sep 20, 2024

yes, need to fixed upstream first.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

@github-actions github-actions bot added the stale label Oct 20, 2024
@zirain
Copy link
Contributor Author

zirain commented Oct 20, 2024

wait envoyproxy/ratelimit#716

@github-actions github-actions bot removed the stale label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability Observability related issues
Projects
None yet
Development

No branches or pull requests

2 participants