New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify inconsistent scaling for queries. #27

Open

mpanaggio opened this issue Jun 22, 2023 · 0 comments

mpanaggio commented Jun 22, 2023

New queries can have inconsistent scaling (they are not on the same absolute scale) when max_query and max_anchor are both above the threshold:

GoogleTrendsAnchorBank/gtab/core.py

Line 1008 in db69456

if max_query >= thresh and max_anchor >= thresh:

I believe this line should read: if max_query >= thresh and max_anchor >=max_query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment