Skip to content

Commit 8be86ba

Browse files
committed
✅ Update ReleaseNote tests
1 parent 51bbc88 commit 8be86ba

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/organisms/ReleaseNote/ReleaseNote.test.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ test('Able to expand it', async () => {
5050

5151
const user = userEvent.setup();
5252

53-
const showMoreButton = screen.getByRole('button', { name: /more/i });
53+
const showMoreButton = await screen.findByRole('button', { name: /more/i });
5454
expect(showMoreButton).toBeInTheDocument();
5555
await user.click(showMoreButton);
5656

@@ -65,7 +65,7 @@ test('Settings startExpanded works as expected', async () => {
6565

6666
const user = userEvent.setup();
6767

68-
const showLessButton = screen.getByRole('button', { name: /less/i });
68+
const showLessButton = await screen.findByRole('button', { name: /less/i });
6969
expect(showLessButton).toBeInTheDocument();
7070
await user.click(showLessButton);
7171

src/organisms/ReleaseNote/ReleaseNote.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ export const ReleaseNote = forwardRef<HTMLDivElement, ReleaseNoteProps>(
7979
new ResizeObserver((entries) => {
8080
if (
8181
entries.at(0) &&
82-
entries[0].target.scrollHeight > entries[0].target.clientHeight
82+
entries[0].target.scrollHeight >
83+
RELEASE_NOTE_RICH_TEXT_COLLAPSED_HEIGHT
8384
) {
8485
setNeedsShowMore(true);
8586
}

0 commit comments

Comments
 (0)