Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TO-DO #1

Open
10 of 21 tasks
eric-figueira opened this issue Apr 17, 2024 · 0 comments
Open
10 of 21 tasks

TO-DO #1

eric-figueira opened this issue Apr 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@eric-figueira
Copy link
Owner

eric-figueira commented Apr 17, 2024

  • Consider ENUM in parameters and fixed types, such as roles, forma_pagamento, status_pedido
  • Use Public ID (UUID or Slug) + Identity
  • Add utility to contain Regex
  • Use lombok for setters + Validations on DTOs
  • Consider dividing controllers into sub-files
  • Solid + Clean Architecture files folders
  • Padronize ResponseEntity return in controllers
  • Separate concerns in controller (create Services, which will in fact access repositories, leaving parameter validations to controller)
  • Improve response and exceptions error messages
  • Replace optionalEntity by orElseThrow statement
  • Refactor update methods in controllers. Make them less verbouses
  • Create proper Mappers
  • Consider remove some DTOs
  • Implement API Logs
  • Remove elses
  • Add proper throw Exceptions
  • Consider changing enums such as PaymentMethod and Role to entities
  • Add swagger documentation
  • Find a way to make partial updates easily
  • Create embedded Address class
  • Add updatedAt, hiredAt, firedAt
@eric-figueira eric-figueira added the enhancement New feature or request label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant