OS-7324 upgrade ipmitool to version 1.8.18 (TritonDataCenter#36)

OS-8157 ipmitool crashes in ipmi_sdr_get_record()
Portions contributed by: Mark Brooks <[email protected]>
Reviewed by: Jason King <[email protected]>
Approved by: Tim Foster <[email protected]>

Author: John Levon

ipmitool/Makefile

@@ -18,14 +18,16 @@
 #
 # CDDL HEADER END
 #
-# Copyright (c) 2012 Joyent Inc., All rights reserved.
+# Copyright 2020 Joyent, Inc.
 #
 
-VER =	ipmitool-1.8.14
+VER =	ipmitool-1.8.18
 
 include ../Makefile.defs
 
 CPPFLAGS +=	-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
+# need INT8_MIN and much other stuff
+CPPFLAGS += -D__EXTENSIONS__
 CFLAGS +=	-g
 
 AUTOCONF_ENV += \

ipmitool/Patches/MAX.diff

@@ -0,0 +1,23 @@
+diff --git a/lib/ipmi_hpmfwupg.c b/lib/ipmi_hpmfwupg.c
+index d63d2c1..03a790f 100644
+--- a/lib/ipmi_hpmfwupg.c
++++ b/lib/ipmi_hpmfwupg.c
+@@ -1,6 +1,7 @@
+ /*
+  * Copyright (c) 2006 Kontron Canada, Inc.  All Rights Reserved.
+  * Copyright (c) 2003 Sun Microsystems, Inc.  All Rights Reserved.
++ * Copyright 2020 Joyent, Inc.
+  *
+  * Redistribution and use in source and binary forms, with or without
+  * modification, are permitted provided that the following conditions
+@@ -48,6 +49,10 @@
+ # include <config.h>
+ #endif
+ 
++#ifndef MAX
++#define MAX(a,b) ((a) > (b) ? (a) : (b))
++#endif
++
+ extern int verbose;
+ 
+ VERSIONINFO gVersionInfo[HPMFWUPG_COMPONENT_ID_MAX];