diff --git a/helpers/assertRecord.js b/helpers/assertRecord.js index 5fcf6c91..0cfa33a3 100644 --- a/helpers/assertRecord.js +++ b/helpers/assertRecord.js @@ -21,7 +21,7 @@ var predicates = { 'RegExp Record': isRegExpRecord }; -module.exports = function assertRecord(recordType, argumentName, value) { +module.exports = function assertRecord(Type, recordType, argumentName, value) { var predicate = predicates[recordType]; if (typeof predicate !== 'function') { throw new $SyntaxError('unknown record type: ' + recordType); diff --git a/package.json b/package.json index 16085a59..b88b7187 100644 --- a/package.json +++ b/package.json @@ -107,6 +107,8 @@ "aud": "^2.0.4", "available-regexp-flags": "^1.0.2", "cheerio": "=1.0.0-rc.3", + "define-accessor-property": "^1.0.0", + "define-data-property": "^1.1.4", "diff": "^5.1.0", "eclint": "^2.8.1", "es-value-fixtures": "^1.4.2", @@ -130,7 +132,7 @@ "object.fromentries": "^2.0.7", "safe-publish-latest": "^2.0.0", "ses": "^0.18.8", - "tape": "^5.7.4" + "tape": "^5.7.5" }, "testling": { "files": "test/index.js", diff --git a/test/helpers/OwnPropertyKeys.js b/test/helpers/OwnPropertyKeys.js index 9948af5b..3c8d72a4 100644 --- a/test/helpers/OwnPropertyKeys.js +++ b/test/helpers/OwnPropertyKeys.js @@ -3,9 +3,10 @@ var test = require('tape'); var hasSymbols = require('has-symbols')(); var $defineProperty = require('es-define-property'); +var defineAccessorProperty = require('define-accessor-property'); +var defineDataProperty = require('define-data-property'); var OwnPropertyKeys = require('../../helpers/OwnPropertyKeys'); -var defineProperty = require('./defineProperty'); test('OwnPropertyKeys', function (t) { t.deepEqual(OwnPropertyKeys({ a: 1, b: 2 }).sort(), ['a', 'b'].sort(), 'returns own string keys'); @@ -22,12 +23,12 @@ test('OwnPropertyKeys', function (t) { t.test('non-enumerables', { skip: !$defineProperty }, function (st) { var o = { a: 1, b: 42, c: NaN }; - defineProperty(o, 'b', { enumerable: false, value: 42 }); - defineProperty(o, 'c', { enumerable: false, get: function () { return NaN; } }); + defineDataProperty(o, 'b', { nonEnumerable: true, value: 42 }); + defineAccessorProperty(o, 'c', { nonEnumerable: true, get: function () { return NaN; } }); if (hasSymbols) { - defineProperty(o, 'd', { enumerable: false, value: true }); - defineProperty(o, 'e', { enumerable: false, get: function () { return true; } }); + defineDataProperty(o, 'd', { nonEnumerable: true, value: true }); + defineAccessorProperty(o, 'e', { nonEnumerable: true, get: function () { return true; } }); } st.deepEqual( diff --git a/test/tests.js b/test/tests.js index 7135a163..b0052099 100644 --- a/test/tests.js +++ b/test/tests.js @@ -7773,7 +7773,7 @@ var es2019 = function ES2019(ES, ops, expectedMissing, skips) { }); test('AsyncFromSyncIteratorContinuation', function (t) { - forEach(v.nonObjects, function (nonObject) { + forEach(v.primitives, function (nonObject) { t['throws']( function () { ES.AsyncFromSyncIteratorContinuation(nonObject); }, TypeError, @@ -14134,7 +14134,7 @@ var es2023 = function ES2023(ES, ops, expectedMissing, skips) { }); test('KeyForSymbol', function (t) { - forEach(v.nonSymbols, function (nonSymbol) { + forEach(v.nonSymbolPrimitives, function (nonSymbol) { t['throws']( function () { ES.KeyForSymbol(nonSymbol); }, TypeError,