Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't automatically vendor OpenSSL #451

Closed
faern opened this issue Jul 25, 2023 · 2 comments · Fixed by #452
Closed

Please don't automatically vendor OpenSSL #451

faern opened this issue Jul 25, 2023 · 2 comments · Fixed by #452

Comments

@faern
Copy link

faern commented Jul 25, 2023

I tried to install cargo-espflash and got compilation errors for OpenSSL (I did not have Perl installed). My system has a perfectly valid OpenSSL installation it can use.

I finally got it to install with OPENSSL_NO_VENDOR=1 cargo install cargo-espflash. But I don't think that should be needed to set explicitly. IMHO using the local install should be the default, and vendoring should be the fallback.

cargo = { version = "0.72.0", features = ["vendored-openssl"] }

@SergioGasquez SergioGasquez linked a pull request Jul 26, 2023 that will close this issue
@SergioGasquez
Copy link
Member

We decided to vendor openSSL since not vendoring it also caused issues for some users. I just created #452 adding some documentation in the README to clarify this and make it easy for user that want to opt out of the default vendored openSSL

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jul 26, 2023
@faern
Copy link
Author

faern commented Jul 26, 2023

Thanks for the extra documentation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants