Please guide me to add my first regression test #19558

V4T54L · 2025-03-09T11:24:07Z

V4T54L
Mar 9, 2025

Hi all, I'm new to open source.
I would like to work on #18926

I have cloned this repo locally to go through the codebase.
Please note that I have manually set up the repo as mentioned in CONTRIBUTING.md

$ make --version
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

$ protoc --version
libprotoc 3.21.12

$ yamllint --version
yamllint 1.29.0

$ jq --version
jq-1.6

$ xz --version
xz (XZ Utils) 5.4.1
liblzma 5.4.1

$ go version
go version go1.24.1 linux/amd64

Now running make verify is throwing error

$ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

$ make verify
PASSES="gofmt" ./scripts/test.sh
Running with --race
...
SUCCESS
PASSES="bom" ./scripts/test.sh
Running with --race
...
'bom' PASSED and completed at Sun Mar  9 04:39:14 PM IST 2025
SUCCESS
golangci/golangci-lint info checking GitHub for tag 'v1.64.6'
golangci/golangci-lint info found version: 1.64.6 for v1.64.6/linux/amd64
golangci/golangci-lint info installed /home/vatsal/go/bin/golangci-lint
PASSES="lint" ./scripts/test.sh
Running with --race
Starting at: Sun Mar  9 04:39:27 PM IST 2025

'lint' started at Sun Mar  9 04:39:27 PM IST 2025
% (cd api && 'golangci-lint' 'run' '--config' '.../etcd/tools/.golangci.yaml' './...')
stderr: ./scripts/test_lib.sh: line 148: golangci-lint: command not found
FAIL: (code:127):
  % (cd api && 'golangci-lint' 'run' '--config' '.../etcd/tools/.golangci.yaml' './...')

FAIL: 'run golangci-lint run --config .../etcd/tools/.golangci.yaml ./...' checking failed (!=0 return code)
There was a Failure in module api, aborting...
FAIL: 'lint' FAILED at Sun Mar  9 04:39:27 PM IST 2025
make: *** [Makefile:102: verify-lint] Error 255

Please note that make build runs successfully.
I'm also facing some errors when running regression tests

$ make test-robustness-issue19179
...
stderr: wal/wal.go:944:103: __fp_walAfterSync.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
FAIL: (code:1):
  % (cd server && 'env' 'CGO_ENABLED=0' 'GO_BUILD_FLAGS=' 'GOOS=linux' 'GOARCH=amd64' 'go' 'build' '-trimpath' '-installsuffix=cgo' '-ldflags=-X=go.etcd.io/etcd/api/v3/version.GitSHA=507c0de-FAILPOINTS' '-o=../bin/etcd' '.')
FAIL: etcd_build (GOARCH=amd64)

And looking at an example PR for a robustness test: #18099
I am unable to find any go code for testing. Is this all that needs to be added for a regression test in general?

You may provide me with some resources to refer and I'll proceed from there.

Thanks.

serathius · 2025-03-10T09:15:16Z

serathius
Mar 10, 2025
Maintainer

$ make test-robustness-issue19179
...
stderr: wal/wal.go:944:103: __fp_walAfterSync.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)

Removing lines between make and failure makes it harder to debug. Please include them.

Feel free to file an issue if there are any commands failing on fresh install. Contributions would be happy to help make onboarding easier.

1 reply

V4T54L Mar 10, 2025
Author

@serathius , thank you for responding.

I feel like it would be some setup issue from my end. Please find the complete logs below:

$ make test-robustness-issue19179
rm -rf /tmp/etcd-v3.5.17-failpoints/
mkdir -p /tmp/etcd-v3.5.17-failpoints/
cd /tmp/etcd-v3.5.17-failpoints/; \
  git clone --depth 1 --branch v3.5.17 https://github.com/etcd-io/etcd.git .; \
  go get go.etcd.io/[email protected]; \
  (cd server; go get go.etcd.io/[email protected]); \
  (cd etcdctl; go get go.etcd.io/[email protected]); \
  (cd etcdutl; go get go.etcd.io/[email protected]); \
  (cd tools/mod; go get go.etcd.io/[email protected]); \
  FAILPOINTS=true ./build;
Cloning into '.'...
remote: Enumerating objects: 1671, done.
remote: Counting objects: 100% (1671/1671), done.
remote: Compressing objects: 100% (1484/1484), done.
remote: Total 1671 (delta 353), reused 665 (delta 145), pack-reused 0 (from 0)
Receiving objects: 100% (1671/1671), 4.28 MiB | 5.58 MiB/s, done.
Resolving deltas: 100% (353/353), done.
Note: switching to '507c0de87bd5034e3de4ab76ebf96b54dae0cd52'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

go: upgraded go.etcd.io/gofail v0.1.0 => v0.2.0
DEPRECATED!!! Use build.sh script instead.

% 'gofail' 'enable' 'server/etcdserver/' 'server/lease/leasehttp' 'server/mvcc/' 'server/wal/' 'server/mvcc/backend/'
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/etcdserver"; using "etcdserver" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/etcdserver"; using "etcdserver" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/etcdserver"; using "etcdserver" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/etcdserver"; using "etcdserver" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/lease/leasehttp"; using "leasehttp" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/mvcc"; using "mvcc" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/wal"; using "wal" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/mvcc/backend"; using "backend" as failpoint path
stderr: missing package for "/tmp/etcd-v3.5.17-failpoints/server/mvcc/backend"; using "backend" as failpoint path
% 'gofail' 'enable' 'server/etcdserver/' 'server/lease/leasehttp' 'server/mvcc/' 'server/wal/' 'server/mvcc/backend/'
% 'rm' '-f' 'bin/etcd'
% (cd server && 'env' 'CGO_ENABLED=0' 'GO_BUILD_FLAGS=' 'GOOS=linux' 'GOARCH=amd64' 'go' 'build' '-trimpath' '-installsuffix=cgo' '-ldflags=-X=go.etcd.io/etcd/api/v3/version.GitSHA=507c0de-FAILPOINTS' '-o=../bin/etcd' '.')
stderr: # go.etcd.io/etcd/server/v3/mvcc/backend
stderr: mvcc/backend/backend.fail.go:7:83: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/backend.fail.go:8:80: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/backend.fail.go:9:82: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/backend.fail.go:10:76: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/batch_tx.fail.go:7:76: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/batch_tx.fail.go:8:75: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/batch_tx.fail.go:9:82: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: mvcc/backend/backend.go:493:123: __fp_defragOpenFileError.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
stderr: mvcc/backend/backend.go:531:113: __fp_defragBeforeCopy.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
stderr: mvcc/backend/backend.go:554:119: __fp_defragBeforeRename.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
stderr: mvcc/backend/backend.go:554:119: too many errors
stderr: # go.etcd.io/etcd/server/v3/wal
stderr: wal/wal.fail.go:7:73: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: wal/wal.fail.go:8:72: too many arguments in call to runtime.NewFailpoint
stderr: have (string, string, bool)
stderr: want (string)
stderr: wal/wal.go:942:106: __fp_walBeforeSync.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
stderr: wal/wal.go:944:103: __fp_walAfterSync.Release undefined (type *"go.etcd.io/gofail/runtime".Failpoint has no field or method Release)
FAIL: (code:1):
  % (cd server && 'env' 'CGO_ENABLED=0' 'GO_BUILD_FLAGS=' 'GOOS=linux' 'GOARCH=amd64' 'go' 'build' '-trimpath' '-installsuffix=cgo' '-ldflags=-X=go.etcd.io/etcd/api/v3/version.GitSHA=507c0de-FAILPOINTS' '-o=../bin/etcd' '.')
FAIL: etcd_build (GOARCH=amd64)
make: *** [tests/robustness/makefile.mk:113: /tmp/etcd-v3.5.17-failpoints/bin] Error 2

$ cd server && 'env' 'CGO_ENABLED=0' 'GO_BUILD_FLAGS=' 'GOOS=linux' 'GOARCH=amd64' 'go' 'build' '-trimpath' '-installsuffix=cgo' '-ldflags=-X=go.etcd.io/etcd/api/v3/version.GitSHA=507c0de-FAILPOINTS' '-o=../bin/etcd' '.'

$

As you can see, I have also tried to execute the command that seems to be failing but it throws no error.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Please guide me to add my first regression test #19558

{{title}}

Replies: 1 comment 1 reply

{{title}}

{{title}}

Select a reply

Please guide me to add my first regression test #19558

V4T54L Mar 9, 2025

Replies: 1 comment · 1 reply

serathius Mar 10, 2025 Maintainer

V4T54L Mar 10, 2025 Author

V4T54L
Mar 9, 2025

Replies: 1 comment 1 reply

serathius
Mar 10, 2025
Maintainer

V4T54L Mar 10, 2025
Author