Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.24 / 1.23 #19417

Open
10 of 16 tasks
ivanvc opened this issue Feb 14, 2025 · 13 comments
Open
10 of 16 tasks

Update to Go 1.24 / 1.23 #19417

ivanvc opened this issue Feb 14, 2025 · 13 comments

Comments

@ivanvc
Copy link
Member

ivanvc commented Feb 14, 2025

What would you like to be added?

Go 1.24.0 was released the day before yesterday. Therefore, Go 1.22 will be out of support when 1.25.0 is released. We should update the main branches to Go 1.24 and the release branches to 1.23.

However, based on previous experience, adopting a new Go minor could take time. So, first, we must ensure that the main branches work fine with 1.24.0. We should also keep an eye on reported issues in the golang/go repository.

Progress track:

Why is this needed?

To keep the project up to date with the latest Go versions.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

Should we update release-3.6 to Go 1.24.0? Or should we keep it at 1.23.6?

@henrybear327
Copy link
Contributor

I can take this if no one is working on it yet @ivanvc

@ahrtr
Copy link
Member

ahrtr commented Feb 14, 2025

Should we update release-3.6 to Go 1.24.0? Or should we keep it at 1.23.6?

I think for any stable branch, we should stick to the existing golang version as long as it's still supported. So keep using 1.23.6 in this case.

@Elbehery Elbehery assigned Elbehery and unassigned Elbehery Feb 14, 2025
@Elbehery
Copy link
Member

Elbehery commented Feb 14, 2025

@henrybear327 sorry, I assigned myself, then I saw ur comment

so sorry 👍🏽

I unassigned myself again 👍🏽

@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

@henrybear327, @Elbehery why don't we split the work? :)

@henrybear327
Copy link
Contributor

@henrybear327, @Elbehery why don't we split the work? :)

@Elbehery you can take it if you are able to work on it now :)

@Elbehery
Copy link
Member

yes I can do tmrw all of it .. I am really sorry that I assigned myself without ur permission

whatever u guys decide I am fine with

@ivanvc
Copy link
Member Author

ivanvc commented Feb 14, 2025

Hey guys, I took etcd-operator because I wanted to test something.

We may need to wait until the kubekins-e2e image has Go 1.24.0 support.

@ivanvc
Copy link
Member Author

ivanvc commented Feb 15, 2025

/assign @Elbehery @ivanvc

@Elbehery
Copy link
Member

@ivanvc bbolt 1.4 was already been bumped etcd-io/bbolt#891

@Elbehery
Copy link
Member

also raft 3.6 was already bumped etcd-io/raft#260 👍🏽

@joshjms
Copy link
Contributor

joshjms commented Feb 16, 2025

I'll help with the etcd repo

@ivanvc
Copy link
Member Author

ivanvc commented Feb 17, 2025

/assign @joshjms
Please open up pull requests for branches release-3.4 and release-3.5. I'm working on the main branch/Go 1.24.0. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants