Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create spec for Proxy.sol #260

Open
mds1 opened this issue Jun 26, 2024 · 1 comment
Open

Create spec for Proxy.sol #260

mds1 opened this issue Jun 26, 2024 · 1 comment

Comments

@mds1
Copy link
Contributor

mds1 commented Jun 26, 2024

nit: it would be more ideal to have a spec for Proxy.sol and point to that, not sure if we do

Additionally, link to it from the OP Stack Manager specs page

Originally posted by @tynes in #236 (comment)

@tynes
Copy link
Contributor

tynes commented Jul 30, 2024

The following functionality is consensus critical:

    modifier proxyCallIfNotAdmin() {
        if (msg.sender == _getAdmin() || msg.sender == address(0)) {
            _;
        } else {
            // This WILL halt the call frame on completion.
            _doProxyCall();
        }
    }

The || address(0) check in particular, where address(0) counts as having admin access. Hardfork system txs spoof address(0) to modify the predeploys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants