Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Standard config" spec should not reference pre-fault-proofs contracts #276

Open
geoknee opened this issue Jul 13, 2024 · 0 comments
Open

Comments

@geoknee
Copy link
Contributor

geoknee commented Jul 13, 2024

There is at least one example here:

https://github.com/ethereum-optimism/specs/blob/dfa8ea9568b0e35827be763fa8e6a2eeb9d90704/specs/protocol/configurability.md?plain=1#L55C1-L56C1

The L2OutputOracle is not used in Fault Proof systems, and standard chains must be on Fault Proofs.

I think in this case the parameter is defined off-chain in the rollup config.

geoknee added a commit to ethereum-optimism/superchain-registry that referenced this issue Jul 13, 2024
geoknee added a commit to ethereum-optimism/superchain-registry that referenced this issue Jul 13, 2024
sebastianst pushed a commit to ethereum-optimism/superchain-registry that referenced this issue Jul 15, 2024
* remove MCP as supported contract version for standard chains

exclude legacy standard candidate chains

* remove "contract_versions_tag" and l2OO tests

we now require fault proof contracts, the l2OO is deprecated on FP chains

* remove unused helper

* remove l2oo.submission_interval and l2oo.challenge_period_seconds

See ethereum-optimism/specs#253

Move l2_block_time to rollup_config section

* replace data availability test with more general rollup config test

* track and validate l2_block_time

ethereum-optimism/specs#276

* update existing chain configs to store block_time = 2

this is actually not properly configurable, yet since op-node will just ignore / overwrite this value

* track and validate sequencing window

Closes #374

* add OptimismPortal2 stamdard params and validation check

* fix bugs

* fix exclusions and devnet params for optimismportal2 params

* remove some exclusions

* remove cruft

* add 5s timeout to RPC calls

* lint

* remove unecessary isFaultProofs bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant