Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): review prague test cases #1299

Open
10 of 27 tasks
danceratopz opened this issue Mar 11, 2025 · 5 comments
Open
10 of 27 tasks

chore(tests): review prague test cases #1299

danceratopz opened this issue Mar 11, 2025 · 5 comments
Assignees
Labels
fork:prague Prague hardfork tracker Tracking issue for projects with sub-tasks

Comments

@danceratopz
Copy link
Member

danceratopz commented Mar 11, 2025

Tracking issue for the ongoing Prague test case review:

Standalone EIPs:

Related EIPs (requests):

Hive simulators:

Interaction:

  • Evaluate EIP interaction.

EIP Updates:

Misc

Feel free to create sub-issues to track comments and suggestions!

@danceratopz danceratopz self-assigned this Mar 11, 2025
@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:prague Prague hardfork labels Mar 11, 2025
@winsvega
Copy link
Contributor

I did eip 7702, so better take some other eip this time

@petertdavies
Copy link
Contributor

Please can I be assigned eip2537_bls_12_381_precompiles

@danceratopz danceratopz pinned this issue Mar 12, 2025
@danceratopz danceratopz added tracker Tracking issue for projects with sub-tasks and removed scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:prague Prague hardfork labels Mar 12, 2025
@marioevz
Copy link
Member

We need to add running invalid block tests in hive against each client and verify that none of the tests pass due to a state-root-mismatch, receipt-root-mismatch or gas-used-mismatch block rejection.

@marioevz
Copy link
Member

Added a first draft of EIP checklists to follow when reviewing these and future EIP tests:
https://github.com/ethereum/execution-spec-tests/blob/eip-checklist/docs/checklist_templates/eip_testing_checklist_template.md

Document is currently live and expect changes in the following hours.

@gurukamath
Copy link
Contributor

Misc

Investigate if the following are covered

  1. Type 4 transaction being sent to an empty address
  2. Type 4 transaction empty authorization list
  3. Type 4 transaction with tx.max_fee_per_gas < tx.max_priority_fee_per_gas
  4. Type 4 transaction tx.max_fee_per_gas < block_env.base_fee_per_gas

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork tracker Tracking issue for projects with sub-tasks
Projects
None yet
Development

No branches or pull requests

5 participants