Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fill,consume): enable xfail/skip marking of tests on a per client basis #1363

Open
danceratopz opened this issue Mar 28, 2025 · 0 comments
Labels
needs-discussion Needs discussion before proceeding scope:consume Scope: Consume command suite scope:fill Scope: fill command type:feat type: Feature

Comments

@danceratopz
Copy link
Member

danceratopz commented Mar 28, 2025

Tldr: Add the ability for clients to mark a test case to conditionally fail or simply be skipped.

End goal:

  • Single source of truth for xfails and skips for all clients (by applying pytest marks directly to ./tests? this seems most robust?)
  • Ability to add a reason for the xfail/skip.
  • Propagation of xfails/skips with reason to hiveview (and other) results for a transparent overview (add registered skips/xfails to the info section of the test fixture JSON?).

Two example use cases (Besu):

  1. Besu's client no longer supports reorgs post-Merge (as its handled by the CL), so can't be expected to pass UncleFromSideChain_Cancun. The test is valid for clients that do maintain this functionality, so shouldn't necessarily be removed.
  2. Besu via consume-rlp fails, but passes consume-engine with tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py::test_invalid_pre_fork_block_with_blob_fields[fork_ShanghaiToCancunAtTime15k-blockchain_test-excess_blob_gas_present_False-blob_gas_used_present_True] (and variations). This is due to the RLPBlockImporter not entirely respecting the Engine API validation rules and would require some, other unnecessary, work to fix.
@danceratopz danceratopz added needs-discussion Needs discussion before proceeding scope:consume Scope: Consume command suite scope:fill Scope: fill command type:feat type: Feature labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion Needs discussion before proceeding scope:consume Scope: Consume command suite scope:fill Scope: fill command type:feat type: Feature
Projects
None yet
Development

No branches or pull requests

2 participants
@danceratopz and others