Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/txpool: fix nonce assignment in local tracker #31496

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

rjl493456442
Copy link
Member

Fixes #31494

@rjl493456442 rjl493456442 requested a review from holiman as a code owner March 26, 2025 07:32
@rjl493456442 rjl493456442 added this to the 1.15.7 milestone Mar 26, 2025
@fjl fjl changed the title core/txpool: fix local tracker core/txpool: fix nonce assignment in local tracker Mar 27, 2025
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK, but the fix looks unintiutive because it changes the semantics of the Nonce method, which is used by the locals tracker. So there are no changes in locals tracker even though it's the thing that's being fixed.

@fjl fjl merged commit 32f36a6 into ethereum:master Mar 28, 2025
3 of 4 checks passed
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TxTracker could miss the pending tx removed by txpool after tx tracker discards the txs under pendingNonce.
2 participants