Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum input duration(ms) should not affect turntable inputs #491

Open
Leuphorie opened this issue Dec 24, 2019 · 1 comment
Open

Minimum input duration(ms) should not affect turntable inputs #491

Leuphorie opened this issue Dec 24, 2019 · 1 comment

Comments

@Leuphorie
Copy link

Setting the minimum input duration to a higher value will also affect analog turntable inputs. There is no need for this, since turntable inputs rarely, or never double fire. Inputs from an analog turntable should not be handled in the same way inputs from a microswitch are, as those are more prone to doublefiring or misfiring in later stages of the microswitch's life. This issue is not present in an analog turntable until way later into its lifetime, making the restriction of the turntable's inputs through the minimum input duration redundant.

The settings should be split: there should be a minimum input duration setting for keys, and a minimum input duration setting for the turntable.

@wcko87
Copy link
Contributor

wcko87 commented Dec 28, 2019

There are two ways to solve this.

Option 1. Split "Minimum input duration(ms)" setting for keys and turntable

  • Two settings: "Minimum key input duration(ms)" and "Minimum turntable input duration(ms)"
  • This will apply for all input modes
    • Keyboard
    • MIDI
    • BM (LR2 scratch)
    • BM (analog scratch ver 1)
    • BM (analog scratch ver 2)
  • Issue: this means more settings for the player to set, may be confusing for player.
  • keyboard players may want both settings to be the same (because keys + scratch use the same keyboard)

Option 2. Disable minimum input duration for BM (analog scratch ver 2) turntable only

  • All other input modes will not be affected.
  • No new setting will be introduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants