-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordination: Upgrade to PHP 8.1 - 8.3 and PHPUnit 10 #652
Comments
I can look into the first 3 and group them in one PR one of the next days. The first 3 should be covered in #656 The |
I don't know if it belongs in this to-do list, but still some exercises, probably older ones, have snake cases in the Stub files. I would prefer having them using camel case too, like the standard is today. E.g. the https://github.com/exercism/php/blob/main/exercises/concept/lasagna/Lasagna.php |
I haven't written documentation on this, yet: We use snake_case for functions, camelCase for methods and PascalCase for classes. Edit: There is no "standard" defined for variable names, yet. And you may make this a separate issue, has nothing to do with PHP updates. |
This is what I think must be done:
XDEBUG_MODE=off
solves this issue (XDebug is "more active" in default mode than before)XDEBUG_MODE=off
required to get CI passing without timeouts (in CI Add PHPUnit 10 and PHP 8.3 #656)composer ci
locally. It was not a problem at all with PHPUnit 9.6 (not even a noticable delay).XDEBUG_MODE=off
doesn't help as much as it did for other exercises. Can be solved by replacingassertArrayNotHasKey($name, $names, ...
withassertFalse(isset($names[$name]), ...
. This reduces runtime from minutes to milliseconds. Problem exists with PHPUnit >= 10.4 || < 11 Test timeout issues #683timeout 54s <command>
as a process based limit per exercise (3x 18 seconds, see forum for calculation details) Test timeout issues #683XDEBUG_MODE=off
for performance reasons. Upgrade to PHP 8.3 and PHPUnit 10 php-test-runner#105XDEBUG_MODE=off
for performance reasons Coordination: Prepare for students code using PHP 8.3 php-representer#155Post-upgrade to modernize further:
rector/rector
for thatIn the whole process, try to avoid re-running the representer and not to trigger re-testing all community solutions. These are very costly to Exercism.
The text was updated successfully, but these errors were encountered: