Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objective-C's integration documentation was outdated #4173

Open
ziggear opened this issue Aug 7, 2024 · 0 comments
Open

Objective-C's integration documentation was outdated #4173

ziggear opened this issue Aug 7, 2024 · 0 comments

Comments

@ziggear
Copy link

ziggear commented Aug 7, 2024

Description

In this discussion with @cipolleschi @okwasniewski , I think the both Objective-C and Swift version of Integration with Existing App - Configuring CocoaPods dependencies part was outdated.

What is the problem?

  1. In this discussion, developers who follow the instructions in this section will mistakenly add pods to their Podfile instead of using the use_react_native! function.
  2. The Swift's integation guide had a 404 issue (Podfile Template linked to a 404 page #4170) , is resolved in the "Next" version, but it still seems to persist in version "0.74". When people first open this documentation, the top navigation bar's version filter defaults to "0.74" instead of "Next", which can cause confusion.

Ultimately, your Podfile should look something similar to this: Podfile Template

How can we address it?

Please review and update the 'Integration with Existing Apps' section of the documentation, including both the Objective-C and Swift versions.

Why is it important?

I believe that there are still many projects that have not yet integrated with React Native, especially some are written in Objective-C. I hope that the 'Integration with Existing Apps' section of the guide can be kept up-to-date, so that more people can easily adopt React Native. Thank you very much!

Who needs this?

iOS Developers

When should this happen (use version numbers if needed)?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant