You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the optional environment variables are booleans. While to documentation does say to set them to true to take effect, the implementation could be more lenient.
The implementation of the boolean variable CONTAINER_VERBOSE is a good example of how to handle these types of toggles:
Feature description
Some of the optional environment variables are booleans. While to documentation does say to set them to
true
to take effect, the implementation could be more lenient.The implementation of the boolean variable
CONTAINER_VERBOSE
is a good example of how to handle these types of toggles:foundryvtt-docker/src/logging.sh
Lines 15 to 17 in 3f4572d
It probably makes sense to explicitly document that the variable should be unset or empty and not
false
to disable a function.Another approach would be to normalize all the expected variables at the start of the entry point.
Motivation
See:
Example
Instead of setting a boolean environment variable exactly to
true
, it can be set to any non-empty value.Compliant variables:
CONTAINER_VERBOSE
Candidate variables:
CONTAINER_PRESERVE_CONFIG
FOUNDRY_IP_DISCOVERY
FOUNDRY_MINIFY_STATIC_FILES
FOUNDRY_PROXY_SSL
FOUNDRY_UPNP
Pitch
To make it easier for users to successfully configure the container.
Code of Conduct
The text was updated successfully, but these errors were encountered: