User::getOption is deprecated (#346)

Author: lens0021

extension.json

@@ -41,7 +41,12 @@
     },
     "AchievementRegister": {
       "class": "MediaWiki\\Extension\\AchievementBadges\\HookHandler\\AchievementRegister",
-      "services": ["MainConfig", "DBLoadBalancer", "RevisionStore"]
+      "services": [
+        "MainConfig",
+        "DBLoadBalancer",
+        "RevisionStore",
+        "UserOptionsLookup"
+      ]
     }
   },
   "SpecialPages": {

includes/HookHandler/AchievementRegister.php

@@ -10,6 +10,7 @@
 use MediaWiki\MediaWikiServices;
 use MediaWiki\Revision\RevisionRecord;
 use MediaWiki\Revision\RevisionStore;
+use MediaWiki\User\UserOptionsLookup;
 use MWTimestamp;
 use User;
 use Wikimedia\Rdbms\ILoadBalancer;
@@ -40,19 +41,27 @@ class AchievementRegister implements
 		 */
 		private $revisionStore;
 
+		/**
+		 * @var UserOptionsLookup
+		 */
+		private $userOptionsLookup;
+
 	/**
 	 * @param Config $config
 	 * @param ILoadBalancer $DBLoadBalancer
 	 * @param RevisionStore $revisionStore
+	 * @param UserOptionsLookup $userOptionsLookup
 	 */
 	public function __construct(
 		Config $config,
 		ILoadBalancer $DBLoadBalancer,
-		RevisionStore $revisionStore
+		RevisionStore $revisionStore,
+		UserOptionsLookup $userOptionsLookup
 	) {
 		$this->config = $config;
 		$this->mDb = $DBLoadBalancer->getMaintenanceConnectionRef( DB_REPLICA );
 		$this->revisionStore = $revisionStore;
+		$this->userOptionsLookup = $userOptionsLookup;
 	}
 
 	private const WEEKDAYS = [
@@ -177,7 +186,7 @@ public function onUserSaveSettings( $user ) {
 		if ( !$this->config->get( Constants::CONFIG_KEY_ENABLE_BETA_FEATURE ) ) {
 			return;
 		}
-		if ( $user->getOption( Constants::PREF_KEY_ACHIEVEMENT_ENABLE ) ) {
+		if ( $this->userOptionsLookup->getOption( $user, Constants::PREF_KEY_ACHIEVEMENT_ENABLE ) ) {
 			Achievement::achieve( [
 				'key' => Constants::ACHV_KEY_ENABLE_ACHIEVEMENT_BADGES,
 				'user' => $user,