New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage-resize-images): maintain aspect ratio of resized images #2115

Open

gregives wants to merge 1 commit into firebase:next from gregives:patch-2

gregives commented Jun 13, 2024

The extension documentation says

This extension keeps the aspect ratio of uploaded images constant and shrinks the image until the resized image’s dimensions are at or under your specified max width and height.

However, it doesn't currently do that: this pull request fixes it.

Fixes #2106

gregives force-pushed the patch-2 branch from 80ac76f to 08afa3f Compare

June 25, 2024 11:45


          fix(storage-resize-images): maintain aspect ratio of resized images

b6a77d9

gregives force-pushed the patch-2 branch from 08afa3f to b6a77d9 Compare

June 25, 2024 11:47

cabljac force-pushed the next branch from b3c7356 to ea44778 Compare

November 6, 2024 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet