Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-resize-images): maintain aspect ratio of resized images #2115

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

gregives
Copy link
Contributor

The extension documentation says

This extension keeps the aspect ratio of uploaded images constant and shrinks the image until the resized image’s dimensions are at or under your specified max width and height.

However, it doesn't currently do that: this pull request fixes it.

Fixes #2106

@cabljac cabljac merged commit a422704 into firebase:next Feb 12, 2025
1 check passed
@cabljac
Copy link
Contributor

cabljac commented Feb 12, 2025

Thanks for your contribution, and your patience in getting this fixed! I will put out a new release with the fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [storage-resize-images] Extension crops the image with default settings.
2 participants