Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling][DevUI] Schema for Chatflow Very Hard to Generate #1806

Open
i2amsam opened this issue Feb 3, 2025 · 4 comments
Open

[Tooling][DevUI] Schema for Chatflow Very Hard to Generate #1806

i2amsam opened this issue Feb 3, 2025 · 4 comments
Labels
bug Something isn't working P0 critical bugs that need to be worked on immediately tooling
Milestone

Comments

@i2amsam
Copy link
Contributor

i2amsam commented Feb 3, 2025

Describe the bug
Testing the chat flow in samples/js-chatbot, going into the chatBotFlow in the DevUI brings up an inscrutable schema and input box that I'm unable to figure out. I think the provided input is missing a required text field, but I'm not sure where.

Image

To repo, check out the js-chatbot at main and run npm run setup && npm run start and try to invoke the flow through the DevUI

@i2amsam i2amsam added bug Something isn't working P0 critical bugs that need to be worked on immediately tooling labels Feb 3, 2025
@i2amsam i2amsam added this to the js-1.0.0 milestone Feb 3, 2025
@MichaelDoyle
Copy link
Member

MichaelDoyle commented Feb 6, 2025

I verified this is rendering the schema exactly as defined. It's just really complex. What do you think we should do here on the Dev UI side?

For better or worse, its exposing a "prompt" object. It can just be a string. It's actually pretty simple though in practice. I assume whoever wrote this code would know what to do in the Dev UI, since they have the context.

Image

@MichaelDoyle
Copy link
Member

FYI @mjchristy @shrutip90 @tonybaroneee

This is WAI. But interesting from a UX standpoint nonetheless.

@MichaelDoyle
Copy link
Member

@i2amsam I don't think there is a PO dev ui ask here. But possibly, the team should prioritize simplifying the sample to make it more approachable? WDYT?

@i2amsam
Copy link
Contributor Author

i2amsam commented Feb 6, 2025

Yeah, maybe this is two things. Agreed neither is P0

  1. Bug in the chatbot sample instead, looking at it, I don't think the more complex input types are used.

  2. Our JSON Schema approach doesn't scale up to the complexity that PartsSchema is not getting to, and maybe we should revisit UX patterns for the complex schemas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0 critical bugs that need to be worked on immediately tooling
Projects
Status: No status
Development

No branches or pull requests

2 participants