Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Remove all references to and usage of flow states #1838

Open
apascal07 opened this issue Feb 4, 2025 · 0 comments
Open

[Go] Remove all references to and usage of flow states #1838

apascal07 opened this issue Feb 4, 2025 · 0 comments
Assignees
@apascal07
Labels
bug Something isn't working go

Comments

@apascal07
Copy link
Collaborator

Describe the bug
There is still quite a bit of flow state-related code left in the Go codebase. A few examples:

https://github.com/firebase/genkit/blob/c3775f9d7a4b01f1022be2486a2409716faf9e3e/go/core/flow_state_store.go
https://github.com/firebase/genkit/blob/c3775f9d7a4b01f1022be2486a2409716faf9e3e/go/core/file_flow_state_store.go

genkit/go/genkit/flow.go

Line 237 in 9ce5221

type flowState[In, Out any] struct {

And a ton more. It all needs to be ripped out and flows simplified to be thin wrappers around action like they are in JS.
@apascal07 apascal07 added bug Something isn't working go labels Feb 4, 2025
@apascal07 apascal07 self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apascal07 apascal07

Labels
bug Something isn't working go
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apascal07