XDG_CURRENT_DESKTOP should not be used as a compositor capability check.

[averageluadev]

Flameshot Version

current version

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

arch latest release 64 bit

Description

flameshot uses XDG CURRENT DESKTOP to check compositor capability
it should not do this

Steps to reproduce

No response

Screenshots or screen recordings

No response

System Information

thinkpad t490s screen
sway / wayland or arch

[mmahmoudian]

@averageluadev can you provide:

1. Why? Are there any references you can cite so we can read them and have a better understanding about this?
2. A suggestion or alternative approach that can be used.

[averageluadev]

@mmahmoudian
sway and hyperland do not set that variable, this causes issues on startup of app
I presume that this happens on other wm's too
a problem is that setting this variable and others relating to session type and desktop env do not fix this issue , as for references I will have to get back to you on that one.

2. I do not have a propper suggestion for an alternative however wayland as a compositior has set capabilities so, checking if user is using wayland would check for some base capabilities.