-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Reuse JIT code path for building AOT wheel #791
Comments
Yes,lots of bugs when compiling&run unittest and benchmark. For example:
and so on... |
Hi @qiaoning yes the C++ side are terribly outdated and needs a thorough cleaning |
@yzh119 I am taking a look. I will open a RFC once I have some more clarity on a reorganization. The work is part of my overall goal to add AMDGPU support for the kernels. |
@abcdabcd987 have you already started on a redesign/refactor? I will collaborate with you in that case. |
No I haven't started. |
#748 did part of the job. A translator from Python interface to C++ interface might be necessary. |
Currently we maintain AOT csrc and JIT csrc separately. Since JIT is the priority and AOT is tested less often, AOT falls out of sync with JIT from time to time. This causes lots of issues (e.g., compilation failure, linking failure, missing symbols at runtime, falling back to JIT) and duplicated work must be paid to bring the changes to AOT. This is clearly not sustainable.
On the other hand, we do want to have a wheel that have some common kernels precompiled.
My proposal is: Get rid of AOT csrc. Use JIT code path to generate and compile kernels during wheel build time.
The text was updated successfully, but these errors were encountered: