Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deb package with source build #208

Open
dogabone opened this issue Jul 17, 2021 · 9 comments
Open

Replace deb package with source build #208

dogabone opened this issue Jul 17, 2021 · 9 comments

Comments

@dogabone
Copy link

There has been some discussion in different threads about this, so I'm raising this issue to gauge interest on such change.

Something like this may be necessary: https://github.com/archlinux/svntogit-community/blob/packages/signal-desktop/trunk/TRADEMARK_CONSENT.txt

@muelli
Copy link

muelli commented Jul 24, 2021

that'd be cool. Then we could skip the use of asar and have much more efficient updates.

@Be-ing
Copy link

Be-ing commented Oct 1, 2021

The Arch PKGBUILD doesn't look too terrible. I think the node helper in flatpak-builder-tools would be required.

@vchernin
Copy link

For inspiration:
https://github.com/flathub/org.standardnotes.standardnotes
flathub/im.riot.Riot#200

Although maybe Signal will consider supporting the Flatpak officially at some point... signalapp/Signal-Desktop#1639

@bermeitinger-b
Copy link
Collaborator

I have tried using StandardNotes as a template.

The biggest problem is that some dependencies manually download their own dependencies which is not possible in the sandboxed building environment.

E.g. sharp wants to download sharp-libvips from Github. With a lot of manual work, this is solvable but it'll become a administrative hellhole to check for all the dependencies.

Then, it's not even guaranteed that the biggest benefit, different arches (#46) works because of some dependencies might not even be built for the given arch.

@muelli
Copy link

muelli commented Jan 19, 2022

E.g. sharp wants to download sharp-libvips from Github.

I've just had the same with lossless-cut

With a lot of manual work, this is solvable but it'll become a administrative hellhole to check for all the dependencies.

yeah, it's work to maintain JavaScript apps...

@khimaros
Copy link

khimaros commented Jan 20, 2022

someone had mentioned https://gitlab.com/undef1/signal-desktop-builder in one of the other closed issues. i haven't investigated to see if it helps with the dependency fetch issue.

@hfiguiere
Copy link

It seem it is used for this https://elagost.com/flatpak/

@spazziale
Copy link

Building from source could also be useful for signalapp/Signal-Desktop#5350, as we can patch it

@julianfairfax
Copy link

Here is a working way to build a Signal Flatpak from source for amd64, and here is the repo I forked, which builds one for arm64.

Example releases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants