-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie auth #120
Comments
Hi @kkkrist, I would assume this would work only for sites that allow cross origin cookies. same-origin option can't work as the cookies would need to originate from restfox.dev. Are you using restfox through the web at restfox.dev? I cannot envision what would be present in the Cookies option in Auth. You can only tell fetch to include credentials. There's no way to pass specific credentials to fetch. So I'm not sure how the user would be able to select credentials they want. A proper cookie system can only be implemented in the desktop version of Restfox, as it has no CORS limitations. It already allows you to send the Cookie header in your requests. We just need to expand it to have a Cookie Manager. So Set-Cookie requests are stored and used by the requests. |
Thank you for your reply! Yes, I'm using restfox.dev and/or a self-hosted version of the same. It could well be that I've missed something, but I think it would be enough to make the Cookies option a boolean setting that just causes the |
Looks like a toggle to me. @kkkrist Maybe you can add a custom option in the settings "Allow CORS calls". Then link it to this: https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials#include |
Hi,
what do you think about adding a cookie auth option?
By default, fetch requests ignore
set-cookie
headers in responses and don't send stored cookies via thecookie
header. Both can be enabled by setting thecredentials
fetch option to"same-origin"
or"include"
.I'm imagining an additional option called "Cookies" in the "Auth" tab which lets the user select the credentials option to add to all relevant fetch calls.
What would be the outline to implement this best?
The text was updated successfully, but these errors were encountered: