Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The path params are deleted when modifying the url #287

Open
kobenguyent opened this issue Oct 18, 2024 · 3 comments
Open

The path params are deleted when modifying the url #287

kobenguyent opened this issue Oct 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kobenguyent
Copy link
Collaborator

I'm not really sure if I missed something but the path params are removed when I edit the url.

Steps:

  • Open any request
  • Add item to path params
  • Edit the url with : to start a path param
  • Notice that path param item is gone
Screen.Recording.2024-10-18.at.11.34.34.mov
@flawiddsouza flawiddsouza added the bug Something isn't working label Oct 18, 2024
@flawiddsouza
Copy link
Owner

This issue happens because we let the path params be modified from the path params section. Postman cleverly avoids the problem by preventing modifications to path params. Only allowing them to be added & renamed from the url.

Video.mp4

Postman also has the same problem if we use the bulk edit feature:

Video.mp4

@kobenguyent
Copy link
Collaborator Author

I'd also love the way how Insomnia handles the path params,

  • dont let user add/edit path params directly but only from url, I guess the same like Postman
  • no bulk edit mode for path params

no bulk edit mode  for path params

insomnia.-.path.params.mov

@flawiddsouza
Copy link
Owner

The reason I haven't yet gone ahead and disabled adding and removing path params is because of one drawback. We'll be removing one feature that restfox has that others don't. This:

image

We can keep multiple values for a single path param if your url doesn't change:

image

Uncheck the first one to quickly check the same path param with another value. It seems quite useful to be removed.

Also what will users who have already added params like this do if we remove the add, delete and checkbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants