Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile: radio buttons for sync method don't activate with screen readers #1702

Open
1 task
domasofan opened this issue Aug 21, 2024 · 9 comments
Open
1 task

Comments

@domasofan
Copy link

Which version of floccus are you using?

5.2.5

How many bookmarks do you have, roughly?

6692

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 129.0.1

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

29.0.3

What kind of WebDAV server are you using? (if relevant)

Nextcloud

Describe the Bug

Hello,

Just tried to use Floccus (5.2.5) with a screenreader (NVDA 2024.3) under Windows (10) with Firefox (129.0.1).
It seems that the radio buttons don't get proper focus when activated with the keyboard using a screen reader.
Clicking them with the mouse emulator seems not to work as well.

Greetings,
Simon

Expected Behavior

It should work as expected. :-)

To Reproduce

Try to create a new profile. then try to activate the radio buttons using the keyboard.

Debug log provided

  • I have provided a debug log file
@domasofan domasofan added the bug label Aug 21, 2024
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@domasofan
Copy link
Author

Figured out that this problem also exists on my Android phone with Floccus 5.2.5 and Talkback as the screen reader.

@marcelklehr
Copy link
Member

Hi @domasofan
Thank you for reporting this!

@github-project-automation github-project-automation bot moved this to Backlog in Floccus Sep 26, 2024
@marcelklehr
Copy link
Member

I sadly cannot reproduce this in the latest version with Gnome's screenreader on Linux. The inputs seem to have all the necessary aria labels, from what I can see. Can you try again?

@marcelklehr marcelklehr moved this from To Do: Bugs to Triaging in Floccus Feb 5, 2025
@domasofan
Copy link
Author

Hi @marcelklehr ,

Just tried with v5.4.4.
Radio buttons in creating a profile still don't activate.
Aria is fine though they can't be activated using the keyboard.

Greetings,
Simon

@marcelklehr
Copy link
Member

Mh, I can reach the radio buttons using the arrow keys.

@domasofan
Copy link
Author

Hi,

Yes they can be reached.
But can they also be activated?

Greetings,
Simon

@marcelklehr
Copy link
Member

marcelklehr commented Feb 9, 2025

Yes, with space, I think. Ah, no they activate directly when reaching them via the arrow keys.

@domasofan
Copy link
Author

Hi,

Thats interesting.
When i try to enable the radio buttons directly that seems not to work.
Though next to the radio button there seems to be a clickable area.
When i use that one the radio buttons above/next to them activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triaging
Development

No branches or pull requests

2 participants